Conversation
|
I am still not sure if it is written correctly. I have seen some situation when the data wasn't refreshed/loaded even if they should. |
|
The PnP ID was dropped, as it seems other devices (e.g. PineTime) also doesn't implement that always. |
1e43a4d to
428a414
Compare
|
I have updated the comments. |
|
FWIW (I also had to refresh my mind to remember the state of those PRs :) ) this PR and AsteroidOS/asteroid-settings#97 both looked good to me. The only reason why these are not merged is because AsteroidOS/meta-asteroid#185 should have been implemented in a different way so it's not Android-specific. With that implemented, I'd gladly merge those PRs. |
|
It is still in my backlog. There is just a lot of other things to do (-; |
|
All good! I just wanted to check I didn't miss anything :) no rush! |
|
I was thinking of those changes. It is question if this change should be blocked by AsteroidOS/meta-asteroid#185 The nemo-qml-plugin-systemsettings technically have same interface. It just provides information which can be confusing for end user. |
This is try to implement Device Info Service
https://www.bluetooth.com/specifications/specs/device-information-service-1-1/
The AsteroidOS/meta-asteroid#184 should be merged in the same time
https://github.com/sailfishos/nemo-qml-plugin-systemsettings/blob/8439e39008e6576001b0aec844bdc52a52da8d34/src/aboutsettings.cpp#L173
[nemo-qml-plugin-systemsettings] Parse manufacturer and device name meta-asteroid#185