Generate asteroidcontrolsplugin qrc via cmake#80
Merged
FlorentRevest merged 1 commit intoAsteroidOS:masterfrom Mar 21, 2026
Merged
Generate asteroidcontrolsplugin qrc via cmake#80FlorentRevest merged 1 commit intoAsteroidOS:masterfrom
FlorentRevest merged 1 commit intoAsteroidOS:masterfrom
Conversation
Member
|
Looks great but this seems to have a merge conflict, could you re-push ? It should be trivial to address since you just delete resources.qrc anyway |
Re-use the already existing listing of controls used for documentation generation as well. This should use qt_add_qml_module() when porting to Qt 6.2 and newer.
PureTryOut
force-pushed
the
cmake-asteroidcontrolsplugin
branch
from
32af4e5 to
9b0216c
Compare
Contributor
Author
|
Done 👍 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use the already existing listing of controls used for documentation generation as well.
This should use qt_add_qml_module() when porting to Qt 6.2 and newer.
Separated from #53 so it doesn't block or is blocked by other things.