fix: menu music restart and flaky RecursiveBacktrackerTest - #14
Merged
Conversation
Aston13
force-pushed
the
fix/menu-music-and-flaky-test
branch
from
March 2, 2026 08:56
4d6bb47 to
7de2a9a
Compare
Aston13
enabled auto-merge (squash)
March 2, 2026 08:56
- AudioManager.playMusic() skips reload when the same track is already playing - RecursiveBacktracker.setExitPath() converted from recursive to iterative - Remove dead fields: MazeGame.ui, MenuManager.ui, Renderer.game, MainMenuPanel.audioManager, ResultOverlayPanel.audioManager, AssetManager.WALL_COMBINATIONS, TouchDpad.BG_PRESSED - Remove unused UI parameter from MazeGame and MenuManager constructors - Remove unread counters in GameLoopTest.StubCallbacks - Replace deprecated new Locale(String) with Locale.of(String) - Use FQN org.gradle.api.GradleException in build.gradle
Aston13
force-pushed
the
fix/menu-music-and-flaky-test
branch
from
March 2, 2026 08:57
7de2a9a to
e7cafa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs Fixed
Main menu music restarts when returning from sub-menu
\AudioManager.playMusic()\ now tracks the current music resource path. If the same track is already playing, the call is a no-op — navigating Settings -> Esc -> Main Menu no longer restarts the music.
Flaky RecursiveBacktrackerTest (StackOverflowError)
Converted \RecursiveBacktracker.setExitPath()\ from a recursive method to an iterative loop with an explicit stack. This eliminates the \StackOverflowError\ that occurred non-deterministically on large or deeply-branching mazes. Verified stable across 5 consecutive test runs.
Warnings Cleaned Up
ew Locale(String)\ with \Locale.of(String)\ in \Start.java\ and \SettingsPanel.java\
Files Changed