fix: prevent accidental persona editor dismissal#9238
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the persistent prop to the v-dialog component in PersonaForm.vue to prevent the dialog from closing accidentally. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
940f93c to
8cb93d3
Compare
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Making the dialog
persistentdisables both scrim and Escape key dismissal; consider whether you want to keep Escape as an explicit close path (e.g., by handling keydown) so keyboard users still have a quick way to exit without losing unsaved-change protection. - With the dialog now persistent, double-check that all flows that previously relied on clicking outside to cancel (e.g., quick-view scenarios) still have an obvious cancel/close affordance in the UI, especially on smaller screens.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Making the dialog `persistent` disables both scrim and Escape key dismissal; consider whether you want to keep Escape as an explicit close path (e.g., by handling keydown) so keyboard users still have a quick way to exit without losing unsaved-change protection.
- With the dialog now persistent, double-check that all flows that previously relied on clicking outside to cancel (e.g., quick-view scenarios) still have an obvious cancel/close affordance in the UI, especially on smaller screens.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Reviewed: disabling both scrim and Escape dismissal is intentional for unsaved-form protection. The existing explicit Cancel, Save, and Delete paths remain unchanged, and this behavior is now stated in the PR body. Adding a separate Escape handler would restore an accidental data-loss path and broaden the change. |
Fixes #8481
Modifications / 改动点
Make the persona editor dialog persistent so outside clicks do not discard unsaved edits.
Use Vuetify persistent behavior; scrim and Escape dismissal are disabled while explicit cancel, save, and delete close paths remain unchanged.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
Summary by Sourcery
Bug Fixes: