Skip to content

fix: enforce non-bypassable ingestion score floors #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeerajCodz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enforce non-bypassable ingestion score floors #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/runtime/ingestion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ use crate::{
};
use serde::{Deserialize, Serialize};

const MIN_IMPORTANCE_SCORE: f32 = 0.2;
const MIN_CONFIDENCE_SCORE: f32 = 0.2;

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct IngestMemoryRequest {
pub id: Option<String>,
Expand Down Expand Up @@ -115,10 +118,12 @@ where
if request.content.trim().is_empty() {
errors.push("content cannot be empty".to_string());
}
if request.importance_score < request.policy.min_importance_score {
let min_importance_score = request.policy.min_importance_score.max(MIN_IMPORTANCE_SCORE);
let min_confidence_score = request.policy.min_confidence_score.max(MIN_CONFIDENCE_SCORE);
if request.importance_score < min_importance_score {
errors.push("importance_score is below write threshold".to_string());
}
if request.confidence_score.unwrap_or(0.0) < request.policy.min_confidence_score {
if request.confidence_score.unwrap_or(0.0) < min_confidence_score {
errors.push("confidence_score is below write threshold".to_string());
}
if !errors.is_empty() {
Expand Down
Loading