Fix adapter tenant and privacy isolation - #15
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VectorSearchRequest.privacy_scope, allowing results with disallowedprivacy_levelto be returned.tenant_id, which could mix graph data across tenants that share auser_idand break tenant isolation.Description
request.privacy_scopeinto aprivacy_levelfilter and adding it as amatch.anyclause in the search payload (src/adapters/qdrant.rs).tenant_idwhen matching endpoint nodes used bymerge_edge, and when matching traversal start nodes inrelated_memory_idsto scope traversals to the tenant (src/adapters/neo4j.rs).tenant_id/user_idviaWHERE all(rel in relationships(p) WHERE rel.tenant_id = $tenant_id AND rel.user_id = $user_id)and includetenant_idinredact_memory_edgesmatches and parameters to avoid cross-tenant redaction.Testing
cargo testand all unit tests passed (11 passed; 0 failed).Codex Task