Merged
Conversation
…lices and spectra
…ng logging and improving error handling
Collaborator
|
@all-contributors please add @MaHaWo for Code, Documentation, Design, Infrastructure, Answering Questions, Review Pull Requests, Tools, Tests, User Testing |
Contributor
|
I've put up a pull request to add @MaHaWo! 🎉 |
Collaborator
|
@all-contributors please add @aobr for Answering Questions, Review Pull Requests, Tools, User Testing |
Contributor
|
I've put up a pull request to add @aobr! 🎉 |
Collaborator
|
@all-contributors please add @nashmit for Code, Design, Infrastructure, Answering Questions |
Contributor
|
I've put up a pull request to add @nashmit! 🎉 |
Collaborator
|
@all-contributors please add @william-h-oliver for Answering Questions, User Testing |
Contributor
|
I've put up a pull request to add @william-h-oliver! 🎉 |
- Added coverage pragma to utils.py for TYPE_CHECKING imports. - Improved test_core_rotation.py with additional tests for galaxy rotation handling gas and stars, including logging and warnings. - Expanded test_core_telescope.py to include tests for telescope type errors and spaxel assignment for stars and gas. - Updated test_cosmology.py to clarify comments regarding angular scale calculations. - Added tests in test_galaxy_alignment.py for gas branch handling in galaxy centering and rotation. - Enhanced test_illustris_handler.py with comprehensive checks for field validation and error handling. - Introduced additional error checks in test_input_handler.py for missing particle fields. - Implemented new tests in test_pipeline.py to ensure padding triggers during sharded runs. - Improved test_pynbody_handler.py with detailed checks for configuration loading and halo data retrieval. - Added new tests in test_spectra_ifu.py for luminosity to flux conversion and velocity Doppler shift handling. - Enhanced test_ssp_grid.py with log field handling in HDF5 and pyPipe3D formats. - Updated test_visualisation.py to validate plotting functions and slice handling in cube visualizations.
update with main
…and installation.rst; enhance pipeline usage examples in pipeline.py
…ng in core modules
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anschaible
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some more changes to the readme and some more test coverage to prepare for publication of RUBIX