Skip to content

ci: pin auto-approve caller to permissions: {}#12

Merged
Aswinmcw merged 1 commit into
mainfrom
ci/caller-permissions-parity
Jul 5, 2026
Merged

ci: pin auto-approve caller to permissions: {}#12
Aswinmcw merged 1 commit into
mainfrom
ci/caller-permissions-parity

Conversation

@Aswinmcw

@Aswinmcw Aswinmcw commented Jul 5, 2026

Copy link
Copy Markdown
Member

Brings blog's caller to parity with portfolio/dashboard/ops-coverage by adding permissions: {}. Blog merged before that fix landed on the others. No behavior change — the reusable workflow mints its own token.

Parity with the other repos — the caller job needs no GITHUB_TOKEN of its own
(the reusable workflow mints its own App token). Fixes CodeQL 'Workflow does
not contain permissions'.
Copilot AI review requested due to automatic review settings July 5, 2026 08:18
@Aswinmcw
Aswinmcw requested review from a team as code owners July 5, 2026 08:18

@Aswincloud-Bot Aswincloud-Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: @Aswinmcw is a member of @Aswincloud/admins.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns this repo’s auto-approve workflow caller with the least-privilege pattern used elsewhere by explicitly disabling default GITHUB_TOKEN permissions at the workflow level. This matches the PR description’s intent (no behavior change because the called reusable workflow is responsible for minting/using its own credentials).

Changes:

  • Add a top-level permissions: {} block to remove default GITHUB_TOKEN permissions.
  • Document why the caller needs no token privileges (credential handling is delegated to the reusable workflow).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 5, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
blog 277444f Commit Preview URL

Branch Preview URL
Jul 05 2026, 08:19 AM

@Aswinmcw
Aswinmcw added this pull request to the merge queue Jul 5, 2026
Merged via the queue into main with commit 20e6908 Jul 5, 2026
5 checks passed
@Aswinmcw
Aswinmcw deleted the ci/caller-permissions-parity branch July 5, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants