ci: pass auto-approve secrets explicitly (drop inherit)#13
Merged
Conversation
secrets: inherit forwards EVERY org secret (Cloudflare, Resend, PATs, ...) into the reusable workflow's run context — far broader than the 3 it needs. Pass only APP_ID, APP_PRIVATE_KEY, WRITE_ACCESS_PAT. Addresses Copilot review feedback.
Aswincloud-Bot
approved these changes
Jul 5, 2026
Aswincloud-Bot
left a comment
Aswincloud-Bot
left a comment
There was a problem hiding this comment.
Auto-approved: @Aswinmcw is a member of @Aswincloud/admins.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
blog | 8b81f81 | Commit Preview URL Branch Preview URL |
Jul 05 2026, 08:28 AM |
There was a problem hiding this comment.
Pull request overview
This PR hardens the auto-approve GitHub Actions workflow by avoiding secrets: inherit when calling an org-level reusable workflow, ensuring only explicitly required secrets are forwarded into the job.
Changes:
- Replaces
secrets: inheritwith an explicit allowlist of three secrets (APP_ID,APP_PRIVATE_KEY,WRITE_ACCESS_PAT). - Adds inline documentation explaining why secret inheritance is avoided (principle of least privilege).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening from Copilot's review:
secrets: inheritforwards all org secrets (Cloudflare, Resend, PROJECTS_TOKEN, ORG_READ_TOKEN, ...) into the auto-approve run. This passes only the 3 the reusable workflow declares —APP_ID,APP_PRIVATE_KEY,WRITE_ACCESS_PAT.I dismissed this in the prior PR with an incorrect claim that inherit 'only forwards needed secrets' — it doesn't. This is the fix.