Display diff of combat stats for upgradeable units#107
Closed
efrec wants to merge 8 commits intoAsyncTI4:mainfrom
Closed
Display diff of combat stats for upgradeable units#107efrec wants to merge 8 commits intoAsyncTI4:mainfrom
efrec wants to merge 8 commits intoAsyncTI4:mainfrom
Conversation
added 3 commits
January 28, 2026 16:41
noob note: still need to test after this
efrec
force-pushed
the
feat/show-unit-combat-upgrades
branch
from
314a8c2 to
8d323a9
Compare
efrec
changed the title
efrec
force-pushed
the
feat/show-unit-combat-upgrades
branch
from
e6fcaef to
fe443cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Displays the delta in combat stats on the unit details of upgradeable units.
When looking around the interface today, I didn't find a quick way to inspect my potential technology picks or unit upgrades. This was the most simple way to view that info, in my opinion, right on the unit detail popover.
Some considerations:
Also, I am a TypeScript noob. I suspect this code is not entirely up to par. I'm not using an LLM/etc. so at least my noob mistakes are natty.
Testing
Working in tests. I noticed a small delay on click which might be normal.
I tested using my local game (first time playing today) and did not notice issues. But I'm a TI4 noob, too, so maybe there are more exotic combinations to test.