Fix Fragmentaion Issue - #29
Closed
razimograbi wants to merge 2 commits into
Closed
Conversation
razimograbi
force-pushed
the
fix_fragmentation_issues
branch
from
July 26, 2026 16:29
de579c6 to
fddf4a2
Compare
razimograbi
marked this pull request as draft
July 26, 2026 16:33
razimograbi
commented
Jul 27, 2026
Comment on lines
+235
to
+238
| if (clientConnection->commandBuffer.find('\n') == std::string::npos) { | ||
| this->rearmSocket(clientSocket); | ||
| return; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
No sure if we can simply check the last character and that's it. hmmmm,
Can the command buffer be populated by other thread ? Because we are using EPOLLONESHOT I don't think so.
Might be able to optimize it to O(1)
@Ataba29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
related to issue: #13
I replaced the standard epoll logic with EPOLLONESHOT.
In order to test the fragmentation run the server on debug mode and then open PowerShell and past this command:
Start sending inputs and then at the end add a \n so we can actually see that it works.
Related issue
Closes #
Type of change
How was this tested?
Checklist
cmake --build build)ctest --test-dir build)