Merged
Conversation
we have our production url now
update url's to production environment
Update node_config.csv
Update node_metadata.csv
Now uses updated script from https://github.com/r-lib/actions/blob/v2/examples/test-coverage.yaml
`search_identifiers()` added; `search_taxa()` now accepts (and uses) multiple fields
…redicates (#272) works when `is_gbif()` returns `TRUE`. So far the filter is parsed correctly but isn't passed to the relevant functions yet; more work to follow
…istency (#278) `collapse()` now only calls functions with a `collapse_` prefix
work in progress, some use cases and tests still fail
First pass at this, as it still only supports one facet value. Note that `show_values()` for type `fields` could benefit from using the occurrences/search API, which will need to be recoded. That API also supports longer facet results and so may be useful for building queries with >1 facet.
- fix bug in atlas_counts() for atlases - continue switching from importFrom to pkg::function() syntax - minor systematic updates: lapply() to map(); rlang::abort() to cli::cli_abort() etc
#278) Also remove dots argument from `galah_call()`, which appears to be unnecessary
- remove obsolete args in `atlas_counts()` - `check()` now uses `galah_call()` instead of `do.call()` - remove `expand` slot from query objects - minor refactoring in namematching - fix bug where `search_taxa()` not accepting `data.frame` as input - many minor adjustments
- remove all unnecessary importFrom statements - specify package for imported functions - switch to cli_abort() and friends
Previously ALA was hard-coded, which is fine for first but not subsequent loads
Detects when the user passes `everything()` to `select.metadata_request()` and parses accordingly. `show_values(all_fields = TRUE)` works unchanged
Also some tidying of other international APIs and associated tests
no more `rlang::abort()` left, minor refactoring to atlas_media()
Mainly ensuring sound files are downloaded correctly
Add @shandiya as contributor, convert Matilda to contributor, remove Peggy
Fix bugs, add tests, add documentation
- enable media downloads for various atlases (mostly broken urls) - re-enable atlas-specific species facets - upgrade UK to pipelines code - various improvements to tests
Basically running now, a few minor bugs still to fix which are being caught by tests
The variables available for facetting (or search in general) 1. differ from those in the occurrence store, and 2. are not available via API. Have added a means to scrape the source Java script for what fields are accepted by the facet arg
First set of changes identified by `check()`
Mainly fixes to predicate construction, large `group_by()` queries, and occurrence downloads
…t an internet connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.