Support borrowed-slice deserialization from cdr-encoding#408
Open
oxkitsune wants to merge 3 commits intoAtostek:masterfrom
Open
Support borrowed-slice deserialization from cdr-encoding#408oxkitsune wants to merge 3 commits intoAtostek:masterfrom
oxkitsune wants to merge 3 commits intoAtostek:masterfrom
Conversation
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pulls in the upstream zero-copy changes from Atostek/cdr-encoding#6.
serde::Deserialize<'de>types can now borrow from the input buffer directly. Byte payloads in particular go through a properbytespath instead of one byte at a time throughseq.Why
The upstream PR targets ROS2 sensor messages (images, point clouds), where copying every byte payload is wasteful. With these adapter changes, we have the plumbing to expose zero-copy reads to RustDDS users in a follow-up. Borrowing types already deserialize through
from_bytes_with, and the read-path API can be extended to hand them out without copying.Compatibility
Public API change:
Decodeimplementors need to add the'delifetime parameter.CDRDeserializerAdapter) are unaffected. Thefor<'de>HRTB keeps the existingDeserializeOwnedrequirement on that path.