fix: Various bugs and style considerations#130
Open
AtriusX wants to merge 5 commits into
Open
Conversation
- Fix == to = in add() method (line 61) preventing ratios HashMap initialization - Fix == to = in default() method (line 90) preventing default world assignment - Simplify redundant null checks in get() method
- Use .use {} block to ensure FileReader is properly closed after JSON parsing
- Prevents file descriptor exhaustion on repeated config loads
- Remove blocking .get() from ListCommand.pageCount() and refactor to async callback pattern - Remove blocking .get() from InfoEvent.onClick() using runOnMainThread extension - Change WaystoneService.process() to return CompletableFuture instead of blocking - Fix LinkEvent async operation using thenAccept instead of thenApplyAsync - Refactor WarpEvent.onClick() to use runEitherOnMainThread for async handling - Add AsyncExtensions utility for bridging CompletableFuture to Bukkit main thread - Add EitherExtensions for convenient Either error handling in async contexts
- Remove duplicate Material.CRAFTING_TABLE entry from WarpValidationService.guiBlocks - Fix KeyService.validateKey() logic for severed lodestone detection - Improve null safety in KeyService by restructuring validation flow - Fix StackSet.remove() to properly handle decrement and removal edge cases
- Pair boss bar and text colors in SimpleTeleportEffect to prevent array bounds mismatch - Extract magic numbers to named constants (TICKS_PER_SECOND, PARTICLE_MULTIPLIER, etc.) - Fix Location.locationCode to return 'unknown' instead of null string for null worlds - Use named parameter ignoreCase=true in MaterialTypeAdapter for clarity - Replace HashMap with ConcurrentHashMap in LocalizationManager for thread safety - Add explicit Int return type to AnimationManager.register() - Replace custom foldResult with Arrow's getOrElse and delete Arrow.kt utility - Add ItemExtensions for type-safe persistent data container access - Add .kotlin/ directory to .gitignore
AtriusX
force-pushed
the
fix/bug-collections
branch
from
a403f3b to
aa33f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.