fix: #136 Add more robust block safety checks#137
Merged
Conversation
The existing checks used are fairly naive about how certain blocks get handled. The check largely worked, but blocks such as signs and other non-obstructing blocks would count as "solid", and this prevent the player from utilizing them in circumstances where the concern is merely teleport safety. To instead ensure that users can get a bit more creative with their options, a new safety service was introduced which adds handling for more explicit edge cases, and enables a new configuration option to determine if liquids count as obstructing blocks.
AtriusX
force-pushed
the
fix/136-signs-blocking-warp
branch
from
d87e155 to
14de07d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing checks used are fairly naive about how certain blocks get handled. The check largely worked, but blocks such as signs and other non-obstructing blocks would count as "solid", and this prevent the player from utilizing them in circumstances where the concern is merely teleport safety.
To instead ensure that users can get a bit more creative with their options, a new safety service was introduced which adds handling for more explicit edge cases, and enables a new configuration option to determine if liquids count as obstructing blocks.