refactor: replace ad hoc random range arithmetic with Random.nextFloat extensions - #19
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…t extensions Scattered from + random.nextFloat() * (until - from) expressions across the scenery and scene renderer made the intended range hard to see at a glance and were easy to get wrong. Add Random.nextFloat(from, until) and Random.nextFloat(until) extensions mirroring the stdlib's ranged nextInt overloads, and switch every matching call site in BackdropScenery.kt and SceneRenderer.kt to use them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Attacktive
force-pushed
the
refactor/random-float-range-extension
branch
from
July 24, 2026 01:07
e457769 to
799f6fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Random.nextFloat(from, until)andRandom.nextFloat(until)extensions in a newRandomFloat.kt, mirroring the stdlib's rangednextIntoverloadsfrom + random.nextFloat() * (until - from)-shaped expressions acrossBackdropScenery.ktandSceneRenderer.ktwith calls to the new extensionsbetween(random, low, high)helper inBackdropScenery.ktin favor of the extensionTest plan
./gradlew compileDebugKotlinpasses./gradlew testDebugUnitTestpasses (includingBackdropSceneryTest's pinned-shape assertions, confirming no numeric regression from the reassociated float arithmetic)🤖 Generated with Claude Code