Skip to content

fix(notifications): send blast push notifications again #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 2 commits into from
Jul 16, 2026
Merged

fix(notifications): send blast push notifications again #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9941df1
fix(notifications): send blast push notifications again
dylanjeffers Jul 16, 2026
276f7ef
fix(notifications): alias blast created_at as timestamp
dylanjeffers Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/notifications/src/tasks/dmNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,11 @@ async function getNewBlasts(
FROM blast
JOIN chat_blast_audience(blast.blast_id) USING (blast_id)
WHERE chat_allowed(from_user_id, to_user_id)
AND ?::INTEGER IS NULL OR to_user_id > ?
AND (?::INTEGER IS NULL OR to_user_id > ?)
ORDER BY to_user_id ASC
LIMIT ?
)
SELECT blast_id, from_user_id AS sender_user_id, to_user_id AS receiver_user_id, created_at FROM targ;
SELECT blast_id, from_user_id AS sender_user_id, to_user_id AS receiver_user_id, created_at AS timestamp FROM targ;
`,
[effectiveBlastId, userId, userId, config.blastUserBatchSize]
)
Expand Down Expand Up @@ -342,12 +342,18 @@ export async function sendDMNotifications(

// Only send notifications that are not too old (avoids flood after plugin downtime).
// Cursor still advances for all so we don't reprocess old ones next tick.
// Blasts are exempt: every recipient carries the blast's created_at, so a
// blast that takes longer than maxAgeMs to work through its audience would
// have all remaining recipients dropped.
const blastSet = new Set<Message | MessageReaction>(blastNotifications)
const maxAgeMs = config.dmNotificationMaxAgeMs
const sendCutoff = maxAgeMs > 0 ? new Date(Date.now() - maxAgeMs) : null
const toSend =
sendCutoff === null
? notifications
: notifications.filter((n) => n.notification.timestamp >= sendCutoff)
: notifications.filter(
(n) => blastSet.has(n) || n.notification.timestamp >= sendCutoff
)
const skipped = notifications.length - toSend.length
if (skipped > 0) {
logger.info(
Expand Down
Loading