Closed
Conversation
* Initial plan * Add NoteMapping.java data model class Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> * Add buildWithMapping method and BuildResult class to PartwiseBuilder Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> * Add note mapping data collection in PartwiseBuilder - Added sheet info collection in processStub() method - Added system info collection in processSystem() method - Added measure info collection in processMeasure() method with bounds and staff data - Added time signature info collection in processTime() method - Added key signature info collection in processKey() method - Added tempo info collection in processDirection() method for MetronomeInter - All collection code is wrapped in try-catch blocks to avoid breaking main export flow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Improve key mode handling with constant - Added DEFAULT_KEY_MODE constant to avoid magic strings - Updated comment to clarify mode detection is not implemented Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add division by zero guards in time calculations - Added checks before division operations to prevent ArithmeticException - Ensures divisions and currentTempo are greater than zero Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add comprehensive note mapping collection in PartwiseBuilder processNote Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> * Integrate note mapping export in ScoreExporter Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> * Add comprehensive NoteMapping specification documentation Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: menlong999 <3749099+menlong999@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: lvyuanfang <lvyuanfang@kingsoft.com>
* fix: export standard midi pitch in geometry sidecars * feat: add playback ordinals to geometry sidecars --------- Co-authored-by: lvyuanfang <lvyuanfang@kingsoft.com>
Contributor
|
Sorry for this late message. I have been very busy in the past few weeks and obviously I overlooked your PR. I noticed you used Copilot AI. But I don't understand the purpose of this PR. The description field is empty, this does not help. You are talking about a "sidecar", what is it precisely for you? Personally, being a biker, for me a sidecar has nothing to do with music!!! You seem to export additional files in various formats. But you don't explain what they are meant for. Thanks in advance for any additional information. |
…zeNote ShapeClassifier.evaluate() can return fewer results than the requested count when the classifier finds insufficient matches. The loop in recognizeNote() was bounded by the requested evalNb instead of the actual array length, causing AIOOBE on sheet #4 during TEXTS step. Use enhanced for-each loop matching the pattern of all other evaluate() callers (ClefBuilder, SymbolsBuilder, KeyExtractor, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Could you explain the purpose of this PR? What are your exported files intended for? I apologize for repeating questions I already asked two weeks ago. /Hervé |
Author
|
Dear Hervé,
Thank you for reaching out and I apologize for the delayed reply.
To clarify the purpose of PR #911: I am working on a way to verify the
output of Audiveris, so I modified the code to export geometry JSON. My
intention was to use this file to test if the original PDF scores could be
accurately rendered with overlays.
1 <https://mail.google.com/mail/u/0/#all/%23thread-f:1860647130711162403>
I forked the Audiveris project for this work, but I inadvertently submitted
the PR to the main upstream repository when I only meant to merge it into
my own fork.
As this PR was submitted in error, I kindly ask that you close or refuse it.
Thank you for your understanding.
Best regards,
Hervé Bitteur ***@***.***> 于2026年4月7日周二 15:38写道：
… *hbitteur* left a comment (Audiveris/audiveris#911)
<#911 (comment)>
@menlong999 <https://github.com/menlong999>
Could you explain the purpose of this PR?
What are your exported files intended for?
They could be very useful, but what exactly are they for? Please clarify
this point.
I apologize for repeating questions I already asked two weeks ago.
I need some basic information before merging your PR.
/Hervé
—
Reply to this email directly, view it on GitHub
<#911 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4TJ23KKWD2GRB7PLDPSYL4USV5RAVCNFSM6AAAAACWSBAUK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOJXGMYTINZTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Lv Yuanfang
|
Contributor
|
Thank you for your clarification. However, I recommend you consult a similar, older discussion in ticket #581. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.