Skip to content

Schedule and coaching#7

Open
AustinSnyd3r wants to merge 12 commits into
mainfrom
scheduleAndCoaching
Open

Schedule and coaching#7
AustinSnyd3r wants to merge 12 commits into
mainfrom
scheduleAndCoaching

Conversation

@AustinSnyd3r

Copy link
Copy Markdown
Owner

No description provided.

@PutMapping("/agreement/withdraw/{agreementId}")
public ResponseEntity<CoachClientAgreementResponseDto> withdrawCoachesAgreementAcceptance(@RequestHeader("X-AUTH-ID") String coachAuthId,
@PathVariable String agreementId){
//TODO: Alert user of withdrawal.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
public ResponseEntity<CoachClientAgreementResponseDto> withdrawCoachesAgreementAcceptance(@RequestHeader("X-AUTH-ID") String coachAuthId,
@PathVariable String agreementId){
//TODO: Alert user of withdrawal.
//TODO: Alert billing service of end of contract.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
}

public CoachClientAgreementResponseDto withdrawCoachesAgreementAcceptance(CoachClientAgreement agreementToChange) {
//TODO: Alter this to mirror the client one.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment

@BeforeEach
void setUp(){
RestAssured.baseURI = "http://localhost:" + port + "/clients/coaching";

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note test

Do not leave debug code in production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants