Skip to content

Single workflow#5

Open
arkiev wants to merge 17 commits intomainfrom
single_workflow
Open

Single workflow#5
arkiev wants to merge 17 commits intomainfrom
single_workflow

Conversation

@arkiev
Copy link
Copy Markdown

@arkiev arkiev commented Mar 19, 2026

The primary contribution of this fork is the addition of a complete DWI preprocessing and QC pipeline integrated as a first-class stage alongside the existing native contrast workflow. This includes automatic DICOM series classification, phase-encoding correction mode selection (rpe_none, rpe_pair, rpe_all, rpe_split), FSL-based DWI preprocessing via dwifslpreproc, tensor fitting to produce ADC and FA maps, and rigid-body T1-to-DWI coregistration using FLIRT — all orchestrated through a new pipeline.py entry point that runs all three stages from a single command. Several refinements were also made to the existing codebase: the ANTs registration check threshold was updated, vial masks are now transformed with nearest-neighbour interpolation to preserve binary values, and the ADC scatter plot was redesigned with open-circle reference markers plotted over the measured values for clearer visual comparison against SPIRIT reference data.

@arkiev arkiev requested a review from tclose March 19, 2026 23:26
@wiz-788c0877ba
Copy link
Copy Markdown

wiz-788c0877ba bot commented Mar 19, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 3 Medium
Software Management Finding Software Management Findings -
Total 3 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

arkiev added 3 commits March 20, 2026 10:50
…API change (plugin → worker) and Click's automatic underscore-to-hyphen conversion in option names (--metric_dir → --metric-dir).
@arkiev arkiev marked this pull request as ready for review March 20, 2026 01:49
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 4.87122% with 1699 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.51%. Comparing base (3216caf) to head (25b5f91).

Files with missing lines Patch % Lines
phantomkit/dwi_processing.py 0.00% 852 Missing ⚠️
phantomkit/phantom_processor.py 0.00% 424 Missing ⚠️
phantomkit/pipeline.py 0.00% 272 Missing ⚠️
phantomkit/plotting/vial_intensity.py 39.31% 61 Missing and 10 partials ⚠️
phantomkit/cli.py 19.11% 55 Missing ⚠️
phantomkit/plotting/visualization.py 4.16% 23 Missing ⚠️
phantomkit/plotting/maps_te.py 89.47% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (4.87%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
- Coverage   68.73%   29.51%   -39.22%     
===========================================
  Files          12       15        +3     
  Lines        1206     2937     +1731     
  Branches      110      404      +294     
===========================================
+ Hits          829      867       +38     
- Misses        350     2034     +1684     
- Partials       27       36        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants