Open
Conversation
Member
SteffenSeckler
left a comment
There was a problem hiding this comment.
Fyi: if the Json parsing is performance relevant, it's likely better to not use the nlohman json parser. See also this discussion: https://www.reddit.com/r/cpp/s/9bEsfCrqeo
Though I suspect that the Json parsing isn't performance relevant...
Contributor
Author
|
From what I've noticed, the parser doesn't introduce any noticable performance issues, probably because the JSONs used are very small. I could go back to a substring-search based approach instead of a parser but this is more elegant and could be useful in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the base and gcc dockerfiles and the documentation for the migration from C/Python API to
pybind11.I have added the gcc Dockerfile only for reference. Ideally, you would publish the image
autopas/build-baseimage on Dockerhub and all dockerfiles which inherit it (archer,clang,code-coverage,doxygen,gcc) should havepybind11andnlohmann-json3-devinstalled without adding those lines since they inherit from that image.If you wouldn't want to include these packages in the
READMEfor these dockerfiles, please delete the lines I've added.