Skip to content

Fix CLI argument checking #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vonky42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CLI argument checking #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions kernels/convolution_milo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,14 @@ def tune(


if __name__ == "__main__":
language = sys.argv[1]
device_name = sys.argv[2]

if len(sys.argv) != 3:
raise ValueError(
f"Usage: python convolution_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv}"
f"Usage: python convolution_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv[1:]}"
)

language = sys.argv[1]
device_name = sys.argv[2]

if language not in ("HIP", "CUDA"):
raise ValueError(f"{language} not valid, specify HIP or CUDA")

Expand Down
8 changes: 4 additions & 4 deletions kernels/dedisp_milo/dedispersion_milo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,14 @@ def tune(


if __name__ == "__main__":
language = sys.argv[1]
device_name = sys.argv[2]

if len(sys.argv) != 3:
raise ValueError(
f"Usage: python dedispersion_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv}"
f"Usage: python dedispersion_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv[1:]}"
)

language = sys.argv[1]
device_name = sys.argv[2]

if language not in ("HIP", "CUDA"):
raise ValueError(f"{language} not valid, specify HIP or CUDA")

Expand Down
6 changes: 3 additions & 3 deletions kernels/gemm_milo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@ def tune(


if __name__ == "__main__":
if len(sys.argv) != 3:
raise ValueError(f"Usage: python gemm_milo.py [language ('HIP', 'OpenCL' or 'CUDA')] [device name], given: {sys.argv[1:]}")

language = sys.argv[1]
device_name = sys.argv[2]

if len(sys.argv) != 3:
raise ValueError(f"Usage: python gemm_milo.py [language ('HIP', 'OpenCL' or 'CUDA')] [device name], given: {sys.argv}")

if language not in ("HIP", "OpenCL", "CUDA"):
raise ValueError(f"{language} not valid, specify HIP, OpenCL or CUDA")

Expand Down
6 changes: 3 additions & 3 deletions kernels/hotspot_milo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,12 @@ def get_results(self):


if __name__ == "__main__":
if len(sys.argv) != 3:
raise ValueError(f"Usage: python hotspot_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv[1:]}")

language = sys.argv[1]
device_name = sys.argv[2]

if len(sys.argv) != 3:
raise ValueError(f"Usage: python hotspot_milo.py [language ('HIP' or 'CUDA')] [device name], given: {sys.argv}")

if language not in ("HIP", "CUDA"):
raise ValueError(f"{language} not valid, specify HIP or CUDA")

Expand Down