Skip to content

Ds log revert#692

Merged
mahbd merged 2 commits intodevfrom
ds-log-revert
May 5, 2026
Merged

Ds log revert#692
mahbd merged 2 commits intodevfrom
ds-log-revert

Conversation

@Muntasib-creator
Copy link
Copy Markdown
Collaborator

@Muntasib-creator Muntasib-creator commented May 5, 2026

Summary

  1. CFT downloading info.json file is corrupted when multiple zeuz node run and tries to read/write. A file locking is introduced to resolve the issue
image
  1. Logging removed from data_store read and write api. The reason of removing is
  • The purpose of logging has been resolved. The issue is already fixed
  • logs consuming a lot of disk spaces without cleaning up.

@Muntasib-creator Muntasib-creator self-assigned this May 5, 2026
@Antu7
Copy link
Copy Markdown
Collaborator

Antu7 commented May 5, 2026

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 4

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 1 suggestion

One regression stands out: the datastore actions now swallow all exceptions and return a generic failure, which removes diagnostic context for network, parsing, and response-shape errors. The Chrome cache locking changes look reasonable overall.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security findings in this PR diff. The changes mostly remove verbose datastore logging and add locking/atomic writes around Chrome-for-Testing cache files without introducing new injection, authz, or secret-handling issues.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

One performance issue stands out: cleanup_old_versions() now holds the shared file lock while deleting Chrome version directories, which can block concurrent readers/writers for the full duration of slow filesystem cleanup.

→ Testing Review

Status: ✅ Completed
Suggestions: 2 suggestions

The PR changes two behavior-sensitive areas but adds no tests around the new failure/edge paths. I found gaps in regression coverage for the datastore helpers and the ChromeForTesting cache/lock logic.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@Muntasib-creator Muntasib-creator requested a review from mahbd May 5, 2026 04:22
@mahbd mahbd merged commit 50bcb03 into dev May 5, 2026
7 checks passed
@mahbd mahbd deleted the ds-log-revert branch May 5, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants