Skip to content

Revert non-PHP SSI parity package changes#517

Closed
chubes4 wants to merge 1 commit into
trunkfrom
revert/ssi-packages-engine-contamination
Closed

Revert non-PHP SSI parity package changes#517
chubes4 wants to merge 1 commit into
trunkfrom
revert/ssi-packages-engine-contamination

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

SSI fixture-matrix parity work consumes blocks-engine/php-transformer through SSI_FIXTURE_MATRIX_BLOCKS_ENGINE_PHP_TRANSFORMER_PATH. Changes under packages/blocks-engine/** are not part of that path and should not ship as SSI parity fixes.

Verification

  • Confirmed diff is limited to:
    • packages/blocks-engine/src/__tests__/theme-source-assets-parity.test.ts
    • packages/blocks-engine/src/theme/index.ts
    • packages/blocks-engine/src/theme/source-assets.ts
  • Ran git diff --check.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenAI GPT-5.5 via OpenCode
  • Used for: Audited the interrupted PR wave, identified the package-side SSI parity contamination, and prepared the narrow corrective revert PR.

@chubes4

chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing this corrective revert after re-checking the source diff from #511. The TypeScript changes are not just SSI fixture noise: they add buildNavigationAnchorCompatCss() to the package source-assets pipeline, export it, and cover it with focused parity tests for replaying source nav anchor selectors through core/navigation wrapper markup. The PHP artifact compiler carries the SSI-facing implementation, so SSI fixture reliability still primarily depends on the PHP transformer, but reverting the package-side implementation would remove a legitimate product improvement for the JS/package transformer surface.

Decision: keep the #511 TypeScript package change; do not merge this revert.

AI assistance

@chubes4 chubes4 closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant