Skip to content

Refactor PHP shell landmark policy#566

Merged
chubes4 merged 1 commit into
trunkfrom
refactor/shell-landmark-policy
Jul 6, 2026
Merged

Refactor PHP shell landmark policy#566
chubes4 merged 1 commit into
trunkfrom
refactor/shell-landmark-policy

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract shared PHP shell/landmark detection into ShellLandmarkPolicy.
  • Reuse it from HtmlTransformer, SemanticParityReporter, and ArtifactCompiler template-part area detection.
  • Add unit coverage for global shell vs content-local landmark boundaries.

Tests

  • composer test:unit
  • composer test

AI assistance

  • AI assistance: Yes
  • Tool(s): openai/gpt-5.5 via OpenCode
  • Used for: Inspected PHP transformer/materialization code, implemented the shell landmark policy extraction, added tests, and ran verification.

@chubes4 chubes4 force-pushed the refactor/shell-landmark-policy branch from e0b96fc to 0b6f0f5 Compare July 6, 2026 23:11
@chubes4 chubes4 merged commit c7d2470 into trunk Jul 6, 2026
1 check passed
@chubes4 chubes4 deleted the refactor/shell-landmark-policy branch July 6, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant