Skip to content

Fix max-width block save shape #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chubes4 wants to merge 1 commit into from
+5 −5
Closed

Fix max-width block save shape #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions php-transformer/src/HtmlToBlocks/Style/StyleAttributeMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ public function serialize(array $style): array
if ( '' !== trim((string) ($dimensions['minHeight'] ?? '')) ) {
$declarations[] = 'min-height:' . trim((string) $dimensions['minHeight']);
}
if ( '' !== trim((string) ($dimensions['maxWidth'] ?? '')) ) {
$declarations[] = 'max-width:' . trim((string) $dimensions['maxWidth']);
}
// Core stores dimensions.maxWidth in block attrs but does not reproduce
// it as an inline wrapper declaration in save(), so emitting it here
// makes otherwise native blocks fail editor validation.

$typography = is_array($style['typography'] ?? null) ? $style['typography'] : array();
$typographyMap = array(
Expand Down
4 changes: 2 additions & 2 deletions php-transformer/tests/unit/block-style-support-conversion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@

$assert('1120px' === ($cardShellAttrs['style']['dimensions']['maxWidth'] ?? ''), '17: section max-width maps to dimensions support', json_encode($cardShellAttrs['style']['dimensions'] ?? array()));
$assert('360px' === ($cardAttrs['style']['dimensions']['maxWidth'] ?? ''), '18: card max-width maps to dimensions support', json_encode($cardAttrs['style']['dimensions'] ?? array()));
$assert(str_contains($cardMarkup, 'max-width:1120px'), '19: rendered section preserves max-width geometry', $cardMarkup);
$assert(str_contains($cardMarkup, 'max-width:360px'), '20: rendered card preserves max-width geometry', $cardMarkup);
$assert(! str_contains($cardMarkup, 'max-width:1120px'), '19: rendered section omits max-width that core save() does not reproduce', $cardMarkup);
$assert(! str_contains($cardMarkup, 'max-width:360px'), '20: rendered card omits max-width that core save() does not reproduce', $cardMarkup);
$assert(! str_contains($cardMarkup, 'style="max-width:1120px;margin:0 auto;padding:5rem 2rem"'), '21: rendered section does not keep unsupported raw style wholesale', $cardMarkup);

$labelHtml = '<section class="pricing"><div class="section-head"><div class="tag">Pricing</div><h2>Simple plans</h2></div><article class="pricing-card"><div class="tier-name">Team</div><div class="tier-price"><span class="amount">$29</span>/mo</div><div class="use-case-result">Launch faster</div></article></section>';
Expand Down
Loading