Skip to content

Preserve button shadows and tighten button diagnostics#568

Merged
chubes4 merged 1 commit into
trunkfrom
fix/saas-yellow-button-parity
Jul 6, 2026
Merged

Preserve button shadows and tighten button diagnostics#568
chubes4 merged 1 commit into
trunkfrom
fix/saas-yellow-button-parity

Conversation

@chubes4

@chubes4 chubes4 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve source button box-shadow as canonical style.shadow on core/button and serialize it into the saved button control.
  • Tighten button/menu visual diagnostics so pseudo-state CSS does not contaminate resting-state comparisons, CSS custom properties resolve before comparison, core button width classes count as width parity, and shadow/glow mismatches are classified.
  • Add PHP coverage for button shadow emission and diagnostic regressions.

Verification

  • php tests/unit/button-style-resolver.php
  • php tests/unit/button-visual-probe-diagnostics.php
  • php tests/unit/block-style-support-conversion.php
  • composer test:unit
  • Scoped SSI matrix run with local runner, this branch as Blocks Engine, this branch php-transformer override, fixture root limited to 15-saas and 3-artist-music, output at /var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/opencode/be-saas-yellow-button-after.json, artifact root at /var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/opencode/be-saas-yellow-button-after-artifacts.

Results

  • SaaS visual mismatch improved from 42.08% in the clean postmerge scorecard to 40.17% in the scoped verification.
  • Artist front-page visual mismatch in the scoped verification: 9.68%.
  • Remaining scoped gate failures are broad visual mismatch/static-import issues, not amber CTA fill/text/shadow parity.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenAI GPT-5.5 via OpenCode
  • Used for: Investigating button parity diagnostics, implementing PHP transformer/diagnostic changes, adding tests, and running verification.

@chubes4 chubes4 merged commit b5b33fd into trunk Jul 6, 2026
1 check passed
@chubes4 chubes4 deleted the fix/saas-yellow-button-parity branch July 6, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant