Add BlockCanvasCover SlotFill - #42
Merged
Merged
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +87 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
ingeniumed
reviewed
Oct 7, 2025
| { children } | ||
| </WritingFlow> | ||
|
|
||
| <BlockCanvasCover.Slot fillProps={ { containerRef: localRef } }> |
There was a problem hiding this comment.
Have a feeling the test failures might be due to the lack of a lock/unlock being used? I could be wrong here.
Author
There was a problem hiding this comment.
It isn't a private API and the other usages of createSlotFill don't need it.
ingeniumed
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by Automattic/vip-real-time-collaboration#58
This adds a SlotFill for the block canvas cover for rendering awareness UI. This provides a more reliable mechanism for rendering over both the iframe based block editor and non-iframe based block editor.