Skip to content

Update block syncing to account for invalid blocks #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ingeniumed wants to merge 2 commits into from
Closed

Update block syncing to account for invalid blocks #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a12bae
Sync the blocks even if there are errors
ingeniumed Oct 16, 2025
513ba20
Add in a try and catch for the block parsing
ingeniumed Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core-data/src/utils/crdt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,18 @@ export function applyPostChangesToCRDTDoc(

switch ( key ) {
case 'blocks': {
// Account for the case where the content has some invalid blocks, and as a result
// the blocks are undefined but the content is not.
if ( changes.content && ! changes.blocks ) {
try {
// Pull in the parsed blocks from the content, and use that as the new value.
newValue = parse( getRawValue( changes.content ) );
} catch ( e ) {
// No-op as one of the blocks is expected to be invalid.
// This ensures that neither the blocks, nor the content are overwritten.
}
}

let currentBlocks = ymap.get( 'blocks' ) as Y.Array< YBlock >;

// Initialize.
Expand Down
Loading