[PHP] Add upstream PHPT harness#740
Open
brandonpayton wants to merge 5 commits into
Open
Conversation
Port the PHP-specific harness, browser VFS/page wiring, PHP 8.3.15 package recipe, libiconv dependency package, and support fixtures from source PR #2 as a scoped checkpoint. General platform fixes and current validation evidence follow in later commits.
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| libiconv | wasm32 | built | 0940adeb |
| libiconv | wasm64 | built | a3254e70 |
| libxml2 | wasm32 | built | f31b85aa |
| libxml2 | wasm64 | built | 2307f0d7 |
| php | wasm32 | built | 9da1b62c |
| rootfs | wasm32 | built | b79c2fb2 |
| shell | wasm32 | built | 6e925d8a |
| node-vfs | wasm32 | built | ead76749 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #736. This replacement keeps the same head commit (
3109baf285c151471b7be1264c9cdc10478d0871) but moves the PR head onto anAutomattic/kandelobranch.Why this is needed
The upstream PHP PHPT suite is the compatibility signal for the PHP package. Without an in-repo harness, failures found during PHP bring-up stay anecdotal: we cannot repeatedly run the same upstream tests, preserve pass/fail/skip artifacts, or review kernel/runtime fixes against a stable test surface.
Why this shape makes sense
This PR keeps the harness separate from the runtime fixes discovered by running it. That makes the first review unit about adopting the PHPT runner, source layout, bounded browser execution, diagnostics, and known harness-specific guards, while the PHP-driven kernel and host fixes land as focused follow-up PRs.
Why this is the correct fix
The harness should model upstream PHPT behavior instead of replacing it with custom smoke tests. Keeping it in the repo gives us repeatable PHP compatibility coverage for both Node and browser hosts and lets later fixes be justified by concrete upstream PHPT failures.
Verification
This is a branch-location correction only; no code was changed from the superseded PR. The replacement head SHA matches #736 exactly.