[PHP] fix: canonicalize cwd after chdir#741
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #721. This replacement keeps the same head commit (
429390c8d27dc5fb46c9b47208e7bbf6a3e7513c) but moves the PR head onto anAutomattic/kandelobranch.Why this is needed
PHP PHPTs exercise
chdir()and relative path resolution heavily. If Kandelo preserves a non-canonical current working directory afterchdir, later file operations can resolve through a stale or syntactically different path than PHP expects.Why this shape makes sense
The fix belongs in cwd handling, not in the PHPT harness. PHP is relying on normal POSIX path behavior, and other packages will hit the same class of bug whenever they mix
chdir()with relative paths.Why this is the correct fix
Canonicalizing cwd after directory changes keeps process state internally consistent and makes subsequent path resolution deterministic. That addresses the runtime invariant directly instead of papering over individual PHP tests.
Verification
Branch-location correction only; replacement head SHA matches #721 exactly.