[PHP] fix: preserve fork environment and trim stale xfails#742
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #722. This replacement keeps the same head commit (
9c02de56346bc640d241ad90ee353c69ae45d5a7) but moves the PR head onto anAutomattic/kandelobranch.Why this is needed
PHPT process tests expect forked children to inherit the parent's environment accurately. Losing or mutating environment state across fork makes PHP subprocess behavior diverge from the Unix process model and creates false PHPT failures.
Why this shape makes sense
The environment inheritance rule is a process-runtime invariant. Fixing it in Kandelo makes PHP, shells, and other fork-heavy packages behave consistently, while trimming stale xfails keeps the harness expectations aligned with the runtime's current behavior.
Why this is the correct fix
Preserving fork environment state at the process boundary matches POSIX expectations and avoids test-specific workarounds. The related xfail cleanup prevents already-fixed behavior from remaining hidden.
Verification
Branch-location correction only; replacement head SHA matches #722 exactly.