[PHP] fix: improve PHP procfs and utility coverage#744
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 7e54390)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #724. This replacement keeps the same head commit (b4133e3) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP and its helper utilities inspect process state through procfs-like paths. Missing or incomplete procfs and utility behavior causes PHP PHPTs to fail for platform reasons rather than PHP reasons.
Why this shape makes sense
The compatibility gap is in the Kandelo process and utility surface. Improving that surface gives PHP and other Unix-oriented packages the same observable process metadata they expect on a normal host.
Why this is the correct fix
Adding the missing procfs and utility coverage exercises the runtime behavior directly and prevents future regressions in the platform APIs the PHPT suite depends on.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #724 exactly.