[PHP] fix: provide default openssl config file#746
Open
brandonpayton wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #726. This replacement keeps the same head commit (2efa15e) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP OpenSSL PHPTs expect a usable default OpenSSL configuration and stable local server behavior under parallel harness execution. Without those, tests fail because the packaged runtime environment is incomplete or races itself.
Why this shape makes sense
The fix combines the default OpenSSL runtime configuration with the PHPT server stabilization needed to make that configuration usable under the upstream harness. Both are package and runtime setup issues exposed by PHP, not PHP source changes.
Why this is the correct fix
Providing the expected default config and making parallel test servers deterministic aligns the Kandelo PHP runtime with upstream PHP test assumptions while avoiding broad skips for OpenSSL coverage.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #726 exactly.