[PHP] fix: apply POSIX file size limit writes#748
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 76c6371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #728. This replacement keeps the same head commit (96b4600) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP tests exercise POSIX resource limits, including file size limits on writes. If writes ignore that limit, Kandelo reports success where a Unix runtime should reject or limit the operation.
Why this shape makes sense
File-size limits are kernel semantics. Enforcing them in the write path fixes all callers, rather than teaching PHP tests to expect Kandelo-specific behavior.
Why this is the correct fix
Applying the limit at write time matches where the kernel has the necessary file and process context, and it brings the runtime behavior in line with POSIX expectations.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #728 exactly.