[PHP] fix: reject unsupported mremap flags#750
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #730. This replacement keeps the same head commit (978e081) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP memory-management tests can probe mremap edge cases. Accepting unsupported flags makes Kandelo silently promise behavior it does not implement.
Why this shape makes sense
A kernel compatibility layer should reject unsupported modes clearly. That gives callers deterministic errors and avoids corrupting runtime state with partially implemented mremap semantics.
Why this is the correct fix
Returning an error for unsupported flags matches the contract better than pretending success. It makes the implemented surface precise and testable.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #730 exactly.