[PHP] fix: split socket datagram and multicast semantics#754
Open
brandonpayton wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #734. This replacement keeps the same head commit (f41e20d) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP stream and socket PHPTs cover datagram delivery, multicast loopback, bind-device queries, and dual-stack listener behavior. The previous socket model failed several of those normal network cases.
Why this shape makes sense
These commits are grouped because they all tighten the Kandelo socket and network compatibility surface. Splitting them more finely would make reviewers chase the same PHP stream behavior across several dependent PRs.
Why this is the correct fix
The branch implements the missing socket semantics in the runtime layer: local datagram delivery, multicast loopback and ABI behavior, SO_BINDTODEVICE shape, and IPv4 and IPv6 port reservation. Those are platform semantics PHP expects from the OS, not harness behavior.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #734 exactly.