[PHP] fix: split TCP close semantics stack#755
Open
brandonpayton wants to merge 2 commits into
Open
Conversation
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| kandelo-sdk | wasm32 | built | bbcaea9f |
| rootfs | wasm32 | built | 3e34a9d0 |
| shell | wasm32 | built | 16aa686a |
| lamp | wasm32 | built | 88379fdd |
| node-vfs | wasm32 | built | 7aecb2ac |
| wordpress | wasm32 | built | 5810f4f5 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes fork-headed PR #735. This replacement keeps the same head commit (3da3a8f) but moves the PR head onto an Automattic/kandelo branch.
Why this is needed
PHP socket tests distinguish graceful TCP close, orderly FIN, and write-after-close behavior. The Kandelo bridged TCP path needs to model those transitions consistently with the kernel socket path.
Why this shape makes sense
This PR intentionally stacks on the SIGPIPE and EPIPE bridge fix because both changes describe the same TCP close contract from different sides of the lifecycle.
Why this is the correct fix
Modeling bridged TCP close as an orderly FIN gives PHP the same state transitions it expects on Unix sockets and avoids converting normal close behavior into test-only special cases.
Stack
Base: integration/kd-6nz-php-phpt-tcp-epipe-sigpipe-base, after the #729 replacement layer.
Verification
Branch-location correction only. Replacement head SHA matches fork-headed PR #735 exactly.