Fix release notes version bump using next_version param#5185
Conversation
Pass the computed next version directly to `android_update_release_notes` using the new `next_version` parameter, instead of relying on the toolkit's built-in calculator which incorrectly caps minor version at 9 (e.g. bumping 8.9 → 9.0 instead of 8.10). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Generated by 🚫 Danger |
There was a problem hiding this comment.
Pull request overview
Updates the Fastlane code-freeze automation to use the release-toolkit’s new next_version parameter when updating Android release notes, aiming to avoid incorrect version bumping (e.g., 8.9 -> 9.0 instead of 8.10).
Changes:
- Switches
android_update_release_notesfromnew_version:tonext_version:in thecode_freezelane.
| ) | ||
| android_update_release_notes( | ||
| new_version: new_version, | ||
| next_version: release_version_next, |
There was a problem hiding this comment.
next_version is being set to release_version_next, which re-computes based on the current version.properties at the time this runs (after you've already bumped to new_beta_version). This can yield the wrong value (e.g., 8.11) and it also ignores an explicit version: passed into the lane, despite the earlier comment that it becomes the source of truth. Consider passing the already-computed new_version (or storing the pre-bump next version in a variable and reusing it here) so the release notes bump matches the intended target version.
| next_version: release_version_next, | |
| next_version: new_version, |
There was a problem hiding this comment.
new_version is the version being frozen (e.g. "8.9"), and we need the section title to be the version after it ("8.10").
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| # release_version_next reads it and computes the next release (e.g. "8.10"). | ||
| android_update_release_notes( | ||
| new_version: new_version, | ||
| next_version: release_version_next, |
There was a problem hiding this comment.
android_update_release_notes is now called with next_version:; with the repo currently pinning fastlane-plugin-wpmreleasetoolkit to 13.8.x in Gemfile.lock, this lane will raise an “unknown option”/parameter error until the lockfile is updated to a toolkit version that includes the new next_version parameter. Please bump the toolkit dependency (Gemfile.lock) alongside this change (or otherwise ensure the new toolkit version is in use in CI).
| next_version: release_version_next, | |
| version: release_version_next, |
There was a problem hiding this comment.
🎗️ Reminder to update release-toolkit once a new version has been released
iangmaia
requested review from
AliSoftware,
MiSikora,
mokagio,
sztomek and
twstokes
and removed request for
a team
iangmaia
added
[Type] Tooling
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Approving to unblock once you'll have 🎗️ pushed a new version of release-toolkit and updated the Gemfile accordingly
14.3.0 adds the `next_version` parameter to the release notes update actions, which the previous commits in this branch already use. --- Generated with the help of Claude Code, https://code.claude.com Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Took the baton and pointed the gem to the stable version @iangmaia released earlier. Going to merge now. |
Summary
Fixes: AINFRA-2242
next_versionparameter ofandroid_update_release_notes(from release-toolkit) to pass the computed next version directly viarelease_version_nextDepends on: wordpress-mobile/release-toolkit#706
Test plan
release_version_nextreturns the correct next version (e.g.8.10when current is8.9-rc-1)🤖 Generated with Claude Code