Fix release notes version bump using next_version param#4099
Conversation
Pass the computed next version directly to `ios_update_release_notes` using the new `next_version` parameter, instead of relying on the toolkit's built-in calculator which incorrectly caps minor version at 9 (e.g. bumping 8.9 → 9.0 instead of 8.10). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Generated by 🚫 Danger |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the iOS Fastlane code-freeze workflow to pass an explicitly computed “next release version” into the release notes updater, avoiding incorrect version bump behavior (e.g., 8.9 → 9.0 instead of 8.10) when relying on the toolkit’s internal calculation.
Changes:
- Switches
ios_update_release_notesto use the newnext_version:parameter, sourced fromrelease_version_next. - Clarifies in-code comments around how
release_version_nextis computed after bumping the version file.
| # release_version_next reads it and computes the next release (e.g. "8.10"). | ||
| ios_update_release_notes( | ||
| new_version: release_version_current, | ||
| next_version: release_version_next, |
There was a problem hiding this comment.
ios_update_release_notes is being called with the new next_version: parameter, but the repo is still locked to fastlane-plugin-wpmreleasetoolkit 13.8.1. Since this PR explicitly depends on an unreleased release-toolkit change, this lane will fail at runtime unless the Gemfile/Gemfile.lock is updated to a version (or git ref) that includes next_version:.
| next_version: release_version_next, |
There was a problem hiding this comment.
🎗️ Reminder to update release-toolkit once a new version has been released
iangmaia
requested review from
AliSoftware,
SergioEstevao,
geekygecko,
mokagio and
twstokes
and removed request for
a team
iangmaia
added
the
[Type] Tooling
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Approving to unblock once you'll have 🎗️ pushed a new version of release-toolkit and updated the Gemfile accordingly
14.3.0 adds the `next_version` parameter to the release notes update actions, which the previous commits in this branch already use. --- Generated with the help of Claude Code, https://code.claude.com Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@mokagio 2 quick notes FYI: the release-toolkit version bump downgraded activesupport (not an issue per se, but good to be aware), and the major bump requires more changes on iOS (I think not on Android, though). Update: It seems we don't use the lane |
Summary
Fixes: AINFRA-2242
next_versionparameter ofios_update_release_notes(from release-toolkit) to pass the computed next version directly viarelease_version_nextDepends on: wordpress-mobile/release-toolkit#706
Test plan
release_version_nextreturns the correct next version (e.g.8.10when current is8.9)🤖 Generated with Claude Code