Fix: pattern selection missing after making duplicate selection

[brookewp]

@alecgeatches found an issue after selecting the same item in succession. When doing so, no patterns are available to select in the modal:

missingpatterns.mov

This appears to be due to a brief moment where __experimentalGetAllowedPatterns returns an empty array, and its state isn't updated. I believe this happened because __experimentalGetAllowedPatterns was extracted from useSelect as a function reference rather than tracking its return value.

Solution

In this PR, __experimentalGetAllowedPatterns(rootClientId) is now inside the selector function, to ensure its result is included in useSelect's state tracking.

restoredpatterns.mov

Testing

After selecting an item in a block (replicated in the art institute and airtable blocks), add another block and make the same selection. You should see patterns to select (ensure custom patterns are present in addition to default).

[github-actions]

Test this PR in WordPress Playground.

[chriszarate]

I believe this happened because __experimentalGetAllowedPatterns was extracted from useSelect as a function reference rather than tracking its return value.

This is correct, and my fault because I don't think I read the docs closely:

When data is only used in an event callback, the data should not be retrieved
on render, so it may be useful to get the selectors function instead.

Don’t use useSelect this way when calling the selectors in the render
function because your component won’t re-render on a data change.

I will do a review to find other spots where I made this mistake.

Note I pushed up a type improvement in ad920af.

[alecgeatches]

Thank you!