UX: clarify naming between site-level and app-level Settings#3886
Merged
Conversation
bcotrim
reviewed
Jun 18, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM and work as described
added 2 commits
June 19, 2026 10:32
epeicher
approved these changes
Jun 19, 2026
epeicher
left a comment
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks @katinthehatsite! I have tested it, and I can see the new Site Settings tab as expected. Also navigating to other tabs work as expected. I would say that once the E2E tests pass, this could be merged. LGTM!
Collaborator
📊 Performance Test ResultsComparing 550d664 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes STU-1694
How AI was used in this PR
It was used to update the tests and do the implementation.
Proposed Changes
npm startSettingstab is now changed toSite SettingsPre-merge Checklist