Skip to content

WIP: contact telemetry requesting #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fmckeogh wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: contact telemetry requesting #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions PocketMesh/Views/Contacts/ContactDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ struct ContactDetailView: View {
// QR sharing state
@State private var showQRShareSheet = false

// Telemetry state
@State private var isLoadingTelemetry = false
@State private var telemetryDataPoints: [LPPDataPoint] = []

init(contact: ContactDTO, showFromDirectChat: Bool = false) {
self.contact = contact
self.showFromDirectChat = showFromDirectChat
Expand All @@ -61,6 +65,9 @@ struct ContactDetailView: View {

// Info section
infoSection

// Telemetry
telemetrySection

// Location section (if available)
if currentContact.hasLocation {
Expand Down Expand Up @@ -265,6 +272,21 @@ struct ContactDetailView: View {
}
}

// MARK: - Telemetry Actions

private func requestTelemetry() async {
guard let binaryService = appState.services?.binaryProtocolService else { return }
isLoadingTelemetry = true
errorMessage = nil
defer { isLoadingTelemetry = false }
do {
let response = try await binaryService.requestTelemetry(from: currentContact.publicKey)
telemetryDataPoints = response.dataPoints
} catch {
errorMessage = error.localizedDescription
}
}

// MARK: - Profile Section

private var profileSection: some View {
Expand Down Expand Up @@ -650,6 +672,45 @@ struct ContactDetailView: View {
}
}


// MARK: - Telemetry Section

private var telemetrySection: some View {
Section {
// Request/Refresh button
Button {
Task { await requestTelemetry() }
} label: {
if isLoadingTelemetry {
HStack {
ProgressView()
Text("Requesting Telemetry…")
}
} else {
Label(telemetryDataPoints.isEmpty ? "Request Telemetry" : "Refresh Telemetry", systemImage: telemetryDataPoints.isEmpty ? "chart.line.uptrend.xyaxis" : "arrow.clockwise")
}
}
.disabled(isLoadingTelemetry)

// Results
if isLoadingTelemetry {
// Optional: additional inline spinner row (button already shows spinner)
} else if telemetryDataPoints.isEmpty {
Text("No telemetry data")
.foregroundStyle(.secondary)
} else {
ForEach(telemetryDataPoints, id: \.self) { dataPoint in
LabeledContent(dataPoint.typeName) {
Text(dataPoint.formattedValue)
.foregroundStyle(.secondary)
}
}
}
} header: {
Text("Telemetry")
}
}

// MARK: - Technical Section

private var technicalSection: some View {
Expand Down