fix(meshcore): decode room server status layout#267
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Room-server status responses use a different 52-byte tail layout than repeater status responses in firmware
1.14.1. The app was decoding every raw status response as repeater-shaped data, so room-server post counters were interpreted as repeater airtime metrics. Raw public-key room status requests also had no safe way to express that distinction at the API boundary.Strategy
Make the layout distinction explicit in the status model and internal parser, then make the public API explicit enough that room-aware callers cannot silently fall back to repeater decoding. Raw public-key requests remain repeater-only, while room-aware requests must flow through a typed contact or node-type path.
Implementation
n_postedandn_post_pushMeshContactandContactTypeVerification
swift test --filter MeshCoreSessionCommandCorrelationTests --filter ProtocolBugFixTestsinMeshCoreswift testinMC1Services