fix(meshcore): handle disabled export private key#268
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
exportPrivateKey()mishandles the firmware's disabled response. The protocol parser emits.disabled, but the current request matcher treated that asnil, which means "ignore this event and keep waiting". When key export is disabled on-device, the call times out instead of surfacing the actual disabled state.Strategy
Keep the existing
async throws -> DataAPI and make disabled an explicit error outcome, matching the existing style used for other feature-gated commands. That avoids widening the API toData?, keeps the change narrow, and makes the failure mode consistent with the rest of the session layer.Implementation
exportPrivateKey()through the error-aware request path.disabledtoMeshCoreError.featureDisabledinstead of ignoring itVerification
swift test --skip-build --filter MeshCoreSessionCommandCorrelationTestsswift testinMeshCore