Skip to content

Adjust SNR thresholds #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avi0n merged 1 commit into from
Mar 27, 2026
Merged

Adjust SNR thresholds #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions MC1/Extensions/SNRQuality+Color.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ extension SNRQuality {
/// SwiftUI color for signal quality indicators.
var color: Color {
switch self {
case .excellent: .green
case .good: .yellow
case .fair, .poor: .red
case .excellent, .good: .green
case .fair: .yellow
case .poor: .red
case .unknown: .secondary
}
}
Expand Down
14 changes: 7 additions & 7 deletions MC1Services/Sources/MC1Services/Models/SNRQuality.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@
///
/// Standard 4-tier scale for signal quality indicators across the app.
public enum SNRQuality: Sendable, Equatable {
case excellent // SNR > 10 dB
case good // SNR > 5 dB
case fair // SNR > 0 dB
case poor // SNR <= 0 dB
case excellent // SNR > +6 dB
case good // SNR > +0 dB
case fair // SNR > -6 dB
case poor // SNR <= -6 dB
case unknown // nil SNR

public init(snr: Double?) {
guard let snr else {
self = .unknown
return
}
if snr > 10 { self = .excellent }
else if snr > 5 { self = .good }
else if snr > 0 { self = .fair }
if snr > 6 { self = .excellent }
else if snr > 0 { self = .good }
else if snr > -6 { self = .fair }
else { self = .poor }
}

Expand Down