docs: add EXAMPLES.md and consolidate CI workflow#7
Merged
Conversation
- Add EXAMPLES.md with expandable real-world use cases (CI pipelines, interactive prompts, TUI monitoring, secret handling, dev workflows, asciinema recording, multi-service testing, AI agent scripting) - Add reference to EXAMPLES.md in README - Remove redundant ci.yml — merge push-to-main trigger into pr.yml with conditional guards so PR-only jobs (title, e2e, review, validate) skip on push events
StructLint — All checks passed62 rules validated against
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Core Changes
- Removed the
ci.ymlGitHub Actions workflow. - Consolidated CI/CD logic, as the removed workflow's steps (tests, build, vulnerability check) are now handled by the
pr.ymlworkflow. - Eliminated
pushtriggers for CI, ensuring all validations run exclusively on pull requests.
Verdict
Approve: The change removes a redundant CI workflow, streamlining the CI/CD setup without losing critical validation steps, as confirmed by the PR description.
Code review performed by GEMINI - gemini-2.5-flash.
Add 9 new examples (local LLMs, k8s port-forwards, IaC approval gates, ML training, MCP servers, SSH tunnels, E2E testing, multi-agent AI, Docker build matrix). Allow *.gif in structlint to fix validation failure on docs/demo.gif.
There was a problem hiding this comment.
Core Changes
- Consolidated CI workflows by removing a redundant
ci.ymland ensuring all validations run on pull requests only. - Updated
.structlint.yamlto allow.giffiles, likely to support documentation assets.
Verdict
Approve: The changes are functional, improve CI/CD structure, and do not introduce any bugs or regressions.
Code review performed by GEMINI - gemini-2.5-flash.
There was a problem hiding this comment.
Core Changes
- Removed a redundant CI workflow (
ci.yml) that was triggered onpushtomain, consolidating all CI checks to run only on pull requests viapr.yml. - Updated
.structlint.yamlto allow.giffiles, resolving a validation error fordocs/demo.gif.
Verdict
Approve: The changes simplify the CI setup and correctly address a linter configuration issue without introducing any bugs or regressions.
Code review performed by GEMINI - gemini-2.5-flash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml— the test/build/vuln-check job was duplicated inpr.ymlpushtrigger entirely — all validations run only on pull requests*.gifin.structlint.yamlto fix validation failure ondocs/demo.gifTest plan
<details>blocks)*.gifallowed