Conversation
Contributor
miky-rola
commented
Apr 11, 2025
- Add function to shutdown server without any dependencies
Closed
Owner
|
Amazing job! |
Az107
requested changes
Apr 12, 2025
Owner
There was a problem hiding this comment.
Its a great job , but a couple of request.
first we can move this methods and mods about the graceful shutdown to a mod in
maybe src/utils.rs or its own.
For the unix implementation its better to finally use libc
that will reduce it to something more like the windows one
extern "C" fn handle_sigint(_: i32) {
println!("\SIGINT recibed (Ctrl+C). Quiting...");
std::process::exit(0);
}
unsafe {
libc::signal(libc::SIGINT, handle_sigint as usize);
}* add basic http request validations * Update .gitignore * Prevent overload the server with infinite o malformed headers * Fix parsing errors and bugs - Now the headers have a maximum (100). - The body read function now will not consume excessive RAM for a malformed request. - Fix keep-alive detection.
…tion and accessibility 🦜🕺 (Az107#32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.