Skip to content

[Shieldy] Fix: Unvalidated user input injected directly into external API URLs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shieldy-security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Shieldy] Fix: Unvalidated user input injected directly into external API URLs #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/src/stockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ class StockData {
}

static async getStockQuote(tickers: string[]) {
const tickers_array = tickers.join(',');
// Validate each ticker: only allow alphanumeric characters, dots, hyphens, and carets
const validTickers = tickers.map(t => t.trim()).filter(t => /^[A-Z0-9.^-]{1,10}$/i.test(t));
if (validTickers.length !== tickers.length) {
throw new Error('One or more ticker symbols contain invalid characters.');
}
const tickers_array = encodeURIComponent(validTickers.join(','));
const url = `${this.yf_quote_url}${tickers_array}${this.yf_quote_ending_url}`;

const response = await axios.get(url);
Expand Down