Restore ThreadPanel KEY_STEP=16 source-pin (post-#55 E2E fix) - #56
Merged
Conversation
…tion (#55 follow-up) The DRY extraction in #55 moved the keyboard nudge step into the shared createResizablePanel default and dropped the local `const KEY_STEP = 16`, which broke the source-level pin in e2e/scenarios/10-thread-panel.spec.ts ("ThreadPanel pins KEY_STEP = 16") and turned post-merge CI red on the E2E job (web unit tests + build + lint stayed green). Re-declare KEY_STEP=16 alongside its MIN/MAX/DEFAULT/STORAGE_KEY siblings and pass it explicitly into the helper so it is wired, not dead. No behaviour change (the helper already defaulted keyStep to 16).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge follow-up to #55.
The DRY resize-helper extraction in #55 moved the keyboard nudge step into the shared
createResizablePaneldefault and dropped the localconst KEY_STEP = 16fromThreadPanel.svelte. That broke the source-level pin inweb/e2e/scenarios/10-thread-panel.spec.ts("ThreadPanel pins KEY_STEP = 16"), turning the post-merge E2E (Playwright scenarios) job red on main (web unit tests, build, lint, and Python suites all stayed green).This re-declares
KEY_STEP = 16alongside itsMIN_PANEL_WIDTH/MAX_PANEL_WIDTH/DEFAULT_PANEL_WIDTH/STORAGE_KEYsiblings and passes it explicitly into the helper, so it is wired rather than dead. No behaviour change — the helper already defaultedkeyStepto 16.Verification:
pnpm --dir web buildgreen;pnpm --dir web testthread-panel spec green (21/21); all four pinned constants present in source.🤖 Generated with Claude Code